feat(libstore): add DELETE method support to FileTransfer#14336
Merged
Ericson2314 merged 3 commits intoNixOS:masterfrom Oct 24, 2025
Merged
feat(libstore): add DELETE method support to FileTransfer#14336Ericson2314 merged 3 commits intoNixOS:masterfrom
Ericson2314 merged 3 commits intoNixOS:masterfrom
Conversation
cole-h
reviewed
Oct 23, 2025
Ericson2314
reviewed
Oct 23, 2025
lovesegfault
force-pushed
the
filetransfer-delete
branch
from
4cb514c to
4625156
Compare
github-actions
bot
added
store
lovesegfault
force-pushed
the
filetransfer-delete
branch
3 times, most recently
from
4c6dcf6 to
23d7404
Compare
xokdvium
reviewed
Oct 23, 2025
lovesegfault
force-pushed
the
filetransfer-delete
branch
from
23d7404 to
34d5f2d
Compare
xokdvium
approved these changes
Oct 23, 2025
lovesegfault
force-pushed
the
filetransfer-delete
branch
from
34d5f2d to
46b601f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
lovesegfault
force-pushed
the
filetransfer-delete
branch
2 times, most recently
from
ad474cc to
dde1156
Compare
xokdvium
reviewed
Oct 24, 2025
lovesegfault
force-pushed
the
filetransfer-delete
branch
from
dde1156 to
ffb25b0
Compare
Ericson2314
approved these changes
Oct 24, 2025
Replace the individual boolean flags (head, post) with a unified HttpMethod enum struct in FileTransferRequest.
Add documentation to FileTransferRequest::verb() explaining that it returns a verb root intended to be concatenated with "ing" to form the gerund.
Add support for HTTP DELETE requests to FileTransfer infrastructure: This enables S3 multipart upload abort functionality via DELETE requests to S3 endpoints.
lovesegfault
force-pushed
the
filetransfer-delete
branch
from
ffb25b0 to
afe5ed8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for HTTP DELETE requests to FileTransfer infrastructure:
This enables S3 multipart upload abort functionality via DELETE requests
to S3 endpoints.
Context
Part-Of: #14330
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.